Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugins): Remove deprecated SerializationPluginProtocol #4028

Open
wants to merge 2 commits into
base: v3.0
Choose a base branch
from
Open

feat(plugins): Remove deprecated SerializationPluginProtocol #4028

wants to merge 2 commits into from

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Feb 26, 2025 •
edited
Loading

Remove the deprecated SerializationPluginProtocol for v3.0.

@provinzkraut provinzkraut requested review from a team as code owners February 26, 2025 09:47
@github-actions github-actions bot added area/docs This PR involves changes to the documentation area/plugins This PR involves changes to the plugins area/private-api This PR involves changes to the privatized API size: small type/feat pr/internal area/dependencies This PR involves changes to the dependencies size: medium labels Feb 26, 2025
@provinzkraut provinzkraut added the do not merge Don't merge this label Feb 26, 2025
@provinzkraut provinzkraut force-pushed the remove-serialization-plugin-protocol branch from 6fb2164 to fcdad74 Compare February 26, 2025 11:12
@provinzkraut provinzkraut mentioned this pull request Feb 25, 2025
Open
22 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (fce0b90) to head (2cb90e6).

Additional details and impacted files 
@@           Coverage Diff           @@
##             v3.0    #4028   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         343      343           
  Lines       15442    15437    -5     
  Branches     1668     1668           
=======================================
- Hits        15172    15168    -4     
+ Misses        135      133    -2     
- Partials      135      136    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut removed the do not merge Don't merge this label Feb 26, 2025
@github-actions github-actions bot added the do not merge Don't merge this label Feb 26, 2025
@provinzkraut provinzkraut enabled auto-merge (squash) February 26, 2025 13:02
@provinzkraut provinzkraut removed the do not merge Don't merge this label Feb 26, 2025
@provinzkraut provinzkraut force-pushed the remove-serialization-plugin-protocol branch from b8c3012 to 2cb90e6 Compare February 26, 2025 13:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Major Issues (required ≤ 2)
7 New Code Smells (required ≤ 3)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/dependencies This PR involves changes to the dependencies area/docs This PR involves changes to the documentation area/plugins This PR involves changes to the plugins area/private-api This PR involves changes to the privatized API pr/internal size: medium size: small type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@provinzkraut