Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove starlette middleware compat #4030

Open
wants to merge 2 commits into
base: v3.0
Choose a base branch
from

Conversation

provinzkraut
Copy link
Member

Remove support for the starlette middleware protocol.

This was added as a backwards compatibility fix when we transition away from the starlette dependency.

@provinzkraut provinzkraut requested review from a team as code owners February 26, 2025 13:13
@github-actions github-actions bot added area/docs This PR involves changes to the documentation area/private-api This PR involves changes to the privatized API area/types This PR involves changes to the custom types size: small type/feat pr/internal labels Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (fce0b90) to head (d805673).

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.0    #4030   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         343      343           
  Lines       15442    15439    -3     
  Branches     1668     1667    -1     
=======================================
- Hits        15172    15170    -2     
+ Misses        135      133    -2     
- Partials      135      136    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut enabled auto-merge (squash) February 26, 2025 13:20
@provinzkraut provinzkraut force-pushed the remove-starlette-middleware-compat branch from 28d5859 to d805673 Compare February 26, 2025 13:22
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Code Smells (required ≤ 3)
7 New Major Issues (required ≤ 2)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation area/private-api This PR involves changes to the privatized API area/types This PR involves changes to the custom types pr/internal size: small type/feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant