Resubmitting #14 - Adding callbacks for draft creation, update, and destroy #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @chrisdpeters, thanks for merging #21 and #23. If you'd like, I can rebase this and make sure it's a clean fast forward merge. |
|
@npafundi No worries. I will be releasing v0.3.4 with your bug fixes soon. These new callbacks will go in v0.4. |
npafundi
force-pushed
the
callbacks
branch
2 times, most recently
from
758ac02 to
893bbc7
Compare
Nine callbacks have been added via ActiveModel::Callbacks: (before | around | after)_draft_creation (before | around | after)_draft_update (before | around | after)_draft_destroy These work very similarly to traditional ActiveRecord callbacks, (e.g. `before_create`), except they are triggered when working with drafts. This commit simply wraps the `draft_creation`, `draft_update`, and `draft_destroy` methods with a `run_callbacks` call. Any callbacks defined on models which have drafts will be run as defined. We only extend models which have drafts, to avoid further cluttering models.
Added 25 specs to test each of the nine draft callbacks. before_draft_creation, around_draft_creation, after_draft_creation before_draft_update, around_draft_update, after_draft_update before_draft_destroy, around_draft_destroy, after_draft_destroy The `Talkative` model contains a few attributes which are modified via these callbacks. The tests check that the attributes are modified correctly, and also check that they're called at the appropriate times.
|
@chrisdpeters I rebased this branch to match master again. Are you still considering pulling this in? |
|
@npafundi Thank you for the rebase. Yes, I would like to get this merged and released within a week or 2. I wanted to spend some time reviewing the tests just to make sure I understand everything fully. I'm sure it's fairly straightforward. |
|
@npafundi Heck, let's merge now. This is next on the list. |
chrisdpeters
added a commit
that referenced
this pull request
Nov 11, 2015
Resubmitting #14 - Adding callbacks for draft creation, update, and destroy
|
Thanks @chrisdpeters! Happy to explain anything, and if I'm missing any tests we can definitely add more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion and comments at #14