Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi: fix panic when publishing data while room is closed #275

Merged
merged 4 commits into from
Dec 21, 2023
Merged

ffi: fix panic when publishing data while room is closed #275

merged 4 commits into from
Dec 21, 2023

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Dec 21, 2023 •
edited
Loading

Instead of panic, it'll send an error on the Python side

@theomonnom theomonnom requested a review from davidzhao December 21, 2023 13:28
@theomonnom theomonnom merged commit e0bda6e into main Dec 21, 2023
11 of 14 checks passed
@theomonnom theomonnom deleted the theo/fix-data-publish branch December 21, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theomonnom @davidzhao