-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C2PA signing #931
Merged
Merged
Add C2PA signing #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #931 +/- ##
===================================================
- Coverage 51.24981% 50.87452% -0.37529%
===================================================
Files 63 64 +1
Lines 6521 6575 +54
===================================================
+ Hits 3342 3345 +3
- Misses 2907 2957 +50
- Partials 272 273 +1
Continue to review full report in Codecov by Sentry.
|
This was referenced Oct 25, 2023
thomshutt
reviewed
Oct 25, 2023
thomshutt
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add C2PA signing to the FFMPEG pipeline.
How does sample output videos look like?
You can download these videos and verify in the C2PA online verify tool: https://contentcredentials.org/verify
Note that this PR
c2pa.published
assertion done by Livepeer Studio, not yetc2pa.transcoded
Detailed changes
c2pa
package which usesc2patool
tool to sign videosc2pa-private-key
andc2pa-certs
to define paths to PK and Certs used for C2PA signaturec2pa
bool param to the VOD request to decide if the output mp4 videos should be signedcopyFileToLocalTmpAndSegment()
not to delete the local copy of the source file, because it's needed to preserve the source signature