Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing apis, update description and summary #1737

Merged
merged 29 commits into from
May 26, 2023
Merged

add missing apis, update description and summary #1737

merged 29 commits into from
May 26, 2023

Conversation

suhailkakar
Copy link
Member

What does this pull request do? Explain your changes. (required)

This PR adds the mission APIs to the api-schema file, update the summary and description of the APIs and roup the APIs by tag.

Specific updates (required)

  • Add the mission APIs to the api-schema file
  • Update the summary and description of the APIs
  • Group the APIs by tag

How did you test each of these updates (required)

  • yarn test
  • openapi validation

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@suhailkakar suhailkakar requested a review from a team as a code owner May 16, 2023 23:21
@vercel
Copy link

vercel bot commented May 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 9:10pm

victorges
victorges approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Made some suggestions but feel free to pick the ones you like and merge without the need of another review.

Thanks for going through all these, a lot of manual work 😩

suhailkakar and others added 9 commits May 19, 2023 20:28
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
2ba7252 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
b9c07aa 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
090fe3e 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
da5d0d0 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
9e699bf 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
645be56 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
6f9402d 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
4fd8f4d 
Co-authored-by: Victor Elias <[email protected]>
@suhailkakar @victorges
Update packages/api/src/schema/api-schema.yaml
bb2b700 
Co-authored-by: Victor Elias <[email protected]>
victorges
victorges approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final LGTM 😄

@victorges victorges merged commit 7ca0b41 into master May 26, 2023
@victorges victorges deleted the api-reference branch May 26, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suhailkakar @victorges