Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Attestation to IPFS #1775

Merged
merged 8 commits into from
Jun 23, 2023
Merged

Store Attestation to IPFS #1775

merged 8 commits into from
Jun 23, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jun 22, 2023

What does this pull request do? Explain your changes. (required)

Add storing Attestation in IPFS.

Related task-runner PR: livepeer/task-runner#202

Specific updates (required)

  • create a new task type export-data which can export any content into IPFS (and potentially other storage providers)
  • schedule export-data task while creating a new attestation
  • update attestation data while receiving the task result
  • allow querying attestation by IPFS CID

How did you test each of these updates (required)

Does this pull request close any open issues?

https://linear.app/livepeer/issue/VID-214/studio-task-runner-add-pinning-video-metadata-to-ipfs

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 11:12am

@leszko leszko changed the title Add storing Attestation to IPFS Store Attestation to IPFS Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1775 (be803b7) into master (7ca0b41) will increase coverage by 0.92311%.
The diff coverage is 71.27072%.

❗ Current head be803b7 differs from pull request most recent head 6e7dc04. Consider uploading reports for the commit 6e7dc04 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1775         +/-   ##
===================================================
+ Coverage   53.80392%   54.72703%   +0.92311%     
===================================================
  Files             75          77          +2     
  Lines           5100        5257        +157     
  Branches        1025        1066         +41     
===================================================
+ Hits            2744        2877        +133     
- Misses          2016        2028         +12     
- Partials         340         352         +12     
Impacted Files Coverage Δ
packages/api/src/config.js 100.00000% <ø> (ø)
packages/api/src/middleware/auth.ts 91.34615% <ø> (ø)
packages/api/src/store/queue.ts 71.64179% <ø> (ø)
packages/api/src/controllers/user.ts 42.27405% <9.09091%> (-0.32950%) ⬇️
packages/api/src/task/scheduler.ts 47.12644% <31.25000%> (-0.04337%) ⬇️
packages/api/src/controllers/helpers.ts 55.55556% <50.00000%> (+2.04205%) ⬆️
packages/api/src/controllers/playback.ts 83.13253% <71.42857%> (-4.92717%) ⬇️
packages/api/src/controllers/asset.ts 63.08411% <78.94737%> (+3.13787%) ⬆️
...ages/api/src/controllers/experiment/attestation.ts 87.27273% <87.27273%> (ø)
packages/api/src/app-router.ts 51.31579% <100.00000%> (+0.03374%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb61a1...6e7dc04. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/config.js 100.00000% <ø> (ø)
packages/api/src/middleware/auth.ts 91.34615% <ø> (ø)
packages/api/src/store/queue.ts 71.64179% <ø> (ø)
packages/api/src/controllers/user.ts 42.27405% <9.09091%> (-0.32950%) ⬇️
packages/api/src/task/scheduler.ts 47.12644% <31.25000%> (-0.04337%) ⬇️
packages/api/src/controllers/helpers.ts 55.55556% <50.00000%> (+2.04205%) ⬆️
packages/api/src/controllers/playback.ts 83.13253% <71.42857%> (-4.92717%) ⬇️
packages/api/src/controllers/asset.ts 63.08411% <78.94737%> (+3.13787%) ⬆️
...ages/api/src/controllers/experiment/attestation.ts 87.27273% <87.27273%> (ø)
packages/api/src/app-router.ts 51.31579% <100.00000%> (+0.03374%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

@leszko leszko marked this pull request as ready for review June 22, 2023 15:55
@leszko leszko requested a review from a team as a code owner June 22, 2023 15:55
@leszko leszko requested review from victorges and iameli June 22, 2023 15:57
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits/naming and a simple change on scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants