Remove unused tasks Import and Transcode #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import was previously used for recordings v1
mjh1
commented
Sep 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
===================================================
+ Coverage 15.35565% 17.70833% +2.35268%
===================================================
Files 19 17 -2
Lines 2390 1920 -470
===================================================
- Hits 367 340 -27
+ Misses 1997 1555 -442
+ Partials 26 25 -1
Continue to review full report in Codecov by Sentry.
|
victorges
approved these changes
Sep 19, 2023
| maxStartTime = math.Max(maxStartTime, startTime) | ||
| } | ||
| } | ||
| glog.Infof("Probed video file assetId=%s filename=%q format=%q width=%d height=%d bitrate=%s startTime=%v maxStreamStartTime=%v %s", |
There was a problem hiding this comment.
@mjh1 I guess this alert is not needed since this line got removed?
There was a problem hiding this comment.
Yeah i'd remove, must not be relevant anymore, I'm not aware we're checking for that condition on the alert anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import was previously used for recordings v1
Transcode was another legacy flow, for creating a "mutation" of existing assets e.g. to ask for a different profile for the master rendition