Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][Vector] Deprecate vector.extractelement/vector.insertelement #113829

Merged
merged 3 commits into from
Feb 19, 2025
Merged

[mlir][Vector] Deprecate vector.extractelement/vector.insertelement #113829

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf3ec2a
[mlir][Vector] Depreciate vector.extractelement/vector.insertelement
Groverkss Oct 27, 2024
12efb83
fix typos
Groverkss Feb 19, 2025
36ed53c
Merge branch 'main' into depreciate-vector-extractelemenmt
Groverkss Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,11 +644,13 @@ def Vector_ExtractElementOp :
Results<(outs AnyType:$result)> {
let summary = "extractelement operation";
let description = [{
Note: This operation is deprecated. Please use vector.extract insert.

Takes a 0-D or 1-D vector and a optional dynamic index position and
extracts the scalar at that position.

Note that this instruction resembles vector.extract, but is restricted to
0-D and 1-D vectors and relaxed to dynamic indices.
0-D and 1-D vectors.
If the vector is 0-D, the position must be std::nullopt.


Expand Down Expand Up @@ -834,11 +836,13 @@ def Vector_InsertElementOp :
Results<(outs AnyVectorOfAnyRank:$result)> {
let summary = "insertelement operation";
let description = [{
Note: This operation is deprecated. Please use vector.insert instead.

Takes a scalar source, a 0-D or 1-D destination vector and a dynamic index
position and inserts the source into the destination at the proper position.

Note that this instruction resembles vector.insert, but is restricted to 0-D
and 1-D vectors and relaxed to dynamic indices.
and 1-D vectors.

It is meant to be closer to LLVM's version:
https://llvm.org/docs/LangRef.html#insertelement-instruction
Expand Down
Loading