[CSKY] Default to unsigned char

[arichardson]

This matches the ABI document found at
https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf

Partially addresses #115957

[llvmbot]

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Alexander Richardson (arichardson)

Changes

This matches the ABI document found at
https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf

Partially addresses #115957

---

Full diff: https://github.com/llvm/llvm-project/pull/115961.diff

2 Files Affected:

• (modified) clang/lib/Driver/ToolChains/Clang.cpp (+1)
• (modified) clang/test/Driver/csky-toolchain.c (+1)

diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 0952262c360185..0476bb49e2c92e 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -1340,6 +1340,7 @@ static bool isSignedCharDefault(const llvm::Triple &Triple) {
       return true;
     return false;
 
+  case llvm::Triple::csky:
   case llvm::Triple::hexagon:
   case llvm::Triple::ppcle:
   case llvm::Triple::ppc64le:
diff --git a/clang/test/Driver/csky-toolchain.c b/clang/test/Driver/csky-toolchain.c
index 66485464652ac8..638ce64ec98cde 100644
--- a/clang/test/Driver/csky-toolchain.c
+++ b/clang/test/Driver/csky-toolchain.c
@@ -3,6 +3,7 @@
 
 // RUN: %clang -### %s --target=csky 2>&1 | FileCheck -check-prefix=CC1 %s
 // CC1: "-cc1" "-triple" "csky"
+// CC1: "-fno-signed-char"
 
 // In the below tests, --rtlib=platform is used so that the driver ignores
 // the configure-time CLANG_DEFAULT_RTLIB option when choosing the runtime lib

[arichardson]

ping

[arichardson]

@zixuan-wu (or anyone else who knows about CSKY) ping

[arichardson]

ping

[zixuan-wu]

LGTM. But I think commit msg should be refined(this PR is not for upstreaming?)

[arichardson]

LGTM. But I think commit msg should be refined(this PR is not for upstreaming?)

Thanks for reviewing!
Sorry what do you mean by commit message needs to be refined? I created this using the spr tool and when merging the description of the PR will be used. Is there something wrong with the description?