Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Add clang/Lex/HLSLRootSignatureTokenKinds.def to clang's modulemap #127839

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

qiongsiwu
Copy link
Contributor

b41b86a added a new textual header clang/Lex/HLSLRootSignatureTokenKinds.def but did not add it to clang's module map. This causes build failure when building llvm with -DLLVM_ENABLE_MODULES=ON. This PR adds the new textual header to the module map and fixes the build break.

Fixing rdar://145148093.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Feb 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 19, 2025

@llvm/pr-subscribers-clang

Author: Qiongsi Wu (qiongsiwu)

Changes

b41b86a added a new textual header clang/Lex/HLSLRootSignatureTokenKinds.def but did not add it to clang's module map. This causes build failure when building llvm with -DLLVM_ENABLE_MODULES=ON. This PR adds the new textual header to the module map and fixes the build break.

Fixing rdar://145148093.


Full diff: https://github.com/llvm/llvm-project/pull/127839.diff

1 Files Affected:

  • (modified) clang/include/module.modulemap (+10-1)
diff --git a/clang/include/module.modulemap b/clang/include/module.modulemap
index fb8e445cb4b72..8489619832a47 100644
--- a/clang/include/module.modulemap
+++ b/clang/include/module.modulemap
@@ -135,7 +135,16 @@ module Clang_Frontend {
 
 module Clang_FrontendTool { requires cplusplus umbrella "clang/FrontendTool" module * { export * } }
 module Clang_Index { requires cplusplus umbrella "clang/Index" module * { export * } }
-module Clang_Lex { requires cplusplus umbrella "clang/Lex" module * { export * } }
+
+module Clang_Lex {
+  requires cplusplus
+  umbrella "clang/Lex"
+
+  textual header "clang/Lex/HLSLRootSignatureTokenKinds.def"
+
+  module * { export * }
+}
+
 module Clang_Parse { requires cplusplus umbrella "clang/Parse" module * { export * } }
 module Clang_Rewrite { requires cplusplus umbrella "clang/Rewrite/Core" module * { export * } }
 module Clang_RewriteFrontend { requires cplusplus umbrella "clang/Rewrite/Frontend" module * { export * } }

Copy link
Member

@cyndyishida cyndyishida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@qiongsiwu qiongsiwu merged commit 85e23fe into llvm:main Feb 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants