Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-rt][test] Fix typo in stderr redirection #98397

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

connieyzhu
Copy link
Contributor

@connieyzhu connieyzhu commented Jul 10, 2024

This patch fixes a typo in the RUN line where stderr should be redirected to stdout instead of the other way around.

Fixed #102385

This patch fixes a typo in the RUN line where stderr should be
redirected to stdout instead of the other way around.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Jul 10, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Connie (connieyzhu)

Changes

This patch fixes a typo in the RUN line where stderr should be redirected to stdout instead of the other way around.


Full diff: https://github.com/llvm/llvm-project/pull/98397.diff

1 Files Affected:

  • (modified) compiler-rt/test/msan/Linux/sigandorset.cpp (+1-1)
diff --git a/compiler-rt/test/msan/Linux/sigandorset.cpp b/compiler-rt/test/msan/Linux/sigandorset.cpp
index da983020a4c68..4d5fcec4ef5cc 100644
--- a/compiler-rt/test/msan/Linux/sigandorset.cpp
+++ b/compiler-rt/test/msan/Linux/sigandorset.cpp
@@ -1,6 +1,6 @@
 // RUN: %clangxx_msan -std=c++11 -O0 -g %s -o %t && not %run %t 2>&1 | FileCheck %s
 // RUN: %clangxx_msan -DLEFT_OK -std=c++11 -O0 -g %s -o %t && not %run %t 2>&1 | FileCheck %s
-// RUN: %clangxx_msan -DRIGHT_OK -std=c++11 -O0 -g %s -o %t && not %run %t 2<&1 | FileCheck %s
+// RUN: %clangxx_msan -DRIGHT_OK -std=c++11 -O0 -g %s -o %t && not %run %t 2>&1 | FileCheck %s
 // RUN: %clangxx_msan -DLEFT_OK -DRIGHT_OK -std=c++11 -O0 -g %s -o %t && %run %t
 // REQUIRES: !android
 

@connieyzhu
Copy link
Contributor Author

cc: @ilovepi @petrhosek @vitalybuka This seems like a typo in redirecting stderr to stdout, but was 2<&1 the intended syntax instead of 2>&1?

@ilovepi
Copy link
Contributor

ilovepi commented Jul 10, 2024

I agree that this looks like a typo, but let’s wait for @vitalybuka or another maintainer of these tests to confirm.

@vitalybuka vitalybuka merged commit ccceeeb into llvm:main Jul 11, 2024
10 checks passed
Copy link

@connieyzhu Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

aaryanshukla pushed a commit to aaryanshukla/llvm-project that referenced this pull request Jul 14, 2024
This patch fixes a typo in the RUN line where stderr should be
redirected to stdout instead of the other way around.
@connieyzhu connieyzhu deleted the compiler-rt-redirect branch July 18, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[llvm-lit] Unsupported redirect in compiler-rt test using lit internal shell
6 participants