Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: llm_judge resume from breakpoint when judging #2225

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

so2liu
Copy link
Contributor

@so2liu so2liu commented Aug 15, 2023

Why are these changes needed?

The GPT-4 is slow and expensive. Therefore, a resume from breakpoint is very useful to save time and cost.

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

@merrymercy
Copy link
Member

@infwinston Could you help review this?

Copy link
Member

@infwinston infwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! left one comment

@so2liu
Copy link
Contributor Author

so2liu commented Aug 24, 2023

all fixed

@merrymercy merrymercy merged commit a4f4b0d into lm-sys:main Aug 24, 2023
@merrymercy
Copy link
Member

@so2liu Thanks! It is merged

@so2liu so2liu deleted the feat/mt_bench-resume-from-breakpoint branch August 24, 2023 09:22
merrymercy added a commit that referenced this pull request Aug 29, 2023
@merrymercy
Copy link
Member

@so2liu Hi, this PR introduced a bug reported in #2332, so I reverted it as a hot fix.
Please fix the bug and submit a new PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants