Dev #75
Open
Dev #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified MFModel to support both OpenAI and Hugging Face embeddings. - Introduced parameter to toggle between embedding sources. - Refactored embedding handling logic for better clarity and flexibility. - Updated initialization to allow specifying custom embedding model names.
… dimensions and optional Hugging Face embeddings - Added parameters 'use_openai_embeddings', 'embedding_model_name', and 'text_dim' to MatrixFactorizationRouter. - Modified initialization to dynamically set 'text_dim' based on the selected embedding model. - Adjusted the router to handle both OpenAI and Hugging Face embeddings seamlessly. - Ensured compatibility with different embedding models by determining 'text_dim' at runtime. - Updated documentation and comments for clarity. This enhancement allows users to choose between OpenAI and Hugging Face embeddings in the MatrixFactorizationRouter, providing greater flexibility and eliminating the hard-coded dependency on OpenAI's embedding dimension.
…proved flexibility in handling Hugging Face authentication. Ensures that the Hugging Face token is properly utilized when initializing routers, supporting local embeddings without external API dependencies.
|
added public get_routed_model method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.