Fix filtering #16
Merged
Fix filtering #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A relay can in theory have 100k+ accounts, out of which only a few hundreds are blocked or explicitly allowed. @talvasconcelos Would the approach in this PR fetch all 100k+ all the time? |
|
yes, and I see your point. i need to rethink this.
the get wasn't retrieving anything from the DB, though.
…On Fri, Jul 14, 2023, 11:58 AM Vlad Stan ***@***.***> wrote:
A relay can in theory have 100k+ accounts, out of which only a few
hundreds are blocked or explicitly allowed.
@talvasconcelos <https://github.com/talvasconcelos> Would the approach in
this PR fetch all 100k+ all the time?
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4F74TXGZUYCVJ4IYEKHHTXQEQ6NANCNFSM6AAAAAA2KEGXOY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@motorina0 filtering is working on testing. Can you please make a final review ? |
motorina0
reviewed
Jul 17, 2023
motorina0
reviewed
Jul 17, 2023
motorina0
reviewed
Jul 17, 2023
motorina0
reviewed
Jul 17, 2023
more copy clean debugging... prints! lol clean console logs fix get users Only get users that explicitly have been allowed or blocked UI UI-2 prevent getting all accounts (false, false is default) remove client side filtering remove prints
talvasconcelos
force-pushed
the
fix_filtering_pubkeys
branch
from
73ababe to
c1ab5ef
Compare
|
Thank you! @talvasconcelos @motorina0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of asking the DB for the accounts, we now call it once and filter client side! Filtering now works as expected.
@motorina0 , when toggling, in the account row, shouldn't the toggles be allowed OR blocked? and never the two at the same time? or is it that a user can be blocked for some time, if the OP whiches? If the later, PR is ready, if not I'll fix it also.
Closes #8