Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mask preserves cell type of the masked tile #3494

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

echeipesh
Copy link
Contributor

@echeipesh echeipesh commented Jan 3, 2023

Overview

Mask and InverseMask functions used dualCombine which used the union of cellTypes between tile and mask for result type. This mostly worked out fine but can produce bad results when either mask or tile had same byte width but different NODATA definitions. The correct behavior for mask operation is to always preserver the cell type of the input tile no matter how silly it or the mask cell type is. It's just better not to ask questions here.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Notes

Closes #3488

@echeipesh echeipesh merged commit 10450de into master Jan 4, 2023
@pomadchin pomadchin deleted the fix/mask-celltype branch March 3, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask/localMask converts celltype
2 participants