Fix: Mask preserves cell type of the masked tile #3494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mask
andInverseMask
functions useddualCombine
which used the union of cellTypes between tile and mask for result type. This mostly worked out fine but can produce bad results when either mask or tile had same byte width but different NODATA definitions. The correct behavior for mask operation is to always preserver the cell type of the input tile no matter how silly it or the mask cell type is. It's just better not to ask questions here.Checklist
Notes
Closes #3488