Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OverlapUnion optimization from CascadedPolygonUnion #644

Merged
merged 1 commit into from
Nov 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -363,14 +363,7 @@ private Geometry unionSafe(Geometry g0, Geometry g1)
*/
private Geometry unionActual(Geometry g0, Geometry g1)
{
Geometry union;

if (unionFun.isFloatingPrecision()) {
union = OverlapUnion.union(g0, g1, unionFun);
}
else {
union = unionFun.union(g0, g1);
}
Geometry union = unionFun.union(g0, g1);
Geometry unionPoly = restrictToPolygons( union );
return unionPoly;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,14 @@
* but it could happen due to snapping. It has been observed
* in other APIs (e.g. GEOS) due to more aggressive snapping.
* It is more likely to happen if a Snap-Rounding overlay is used.
* <p>
* <b>NOTE: Test has shown that using this heuristic impairs performance.
* It has been removed from use.</b>
*
*
* @author mbdavis
*
* @deprecated due to impairing performance
*
*/
public class OverlapUnion
Expand Down