Add SQLite parser for iOS Accounts (Accounts3.sqlite) file #4926
Conversation
|
Hi @joachimmetz, I am not sure why test_docs / build (3.12, docs) failed. Can you show me where the error is? Other eight tests are successful. |
|
@studiawan I'm a bit preoccupied at the moment will try to take a look as soon as time permits |
…al newline missing
| self.username = None | ||
| self.identifier = None | ||
| self.owning_bundle_id = None | ||
|
|
There was a problem hiding this comment.
style guide nit: have 2 empty lines
| """Retrieves a date and time value from the row. | ||
|
|
||
| Args: | ||
| query_hash (int): hash of the query, that uniquely |
There was a problem hiding this comment.
style guide nit: have 2 indentation spaces
| """iOS accounts event data. | ||
|
|
||
| Attributes: | ||
| date (dfdatetime.DateTimeValues): date and time the account |
There was a problem hiding this comment.
for consistency across the codebase changing this to creation_time
| account_type (str): account type. | ||
| username (str): user name. | ||
| identifier (str): identifier. | ||
| owning_bundle_id (str): owning bundle identifier of the app |
There was a problem hiding this comment.
style guide nit: id => identifier
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4926 +/- ##
==========================================
+ Coverage 85.05% 85.06% +0.01%
==========================================
Files 431 432 +1
Lines 38648 38683 +35
==========================================
+ Hits 32873 32907 +34
- Misses 5775 5776 +1 ☔ View full report in Codecov by Sentry. |
One line description of pull request
Add SQLite parser for iOS Accounts (Accounts3.sqlite) file
Description:
I add/edit several files:
Related issue (if applicable): fixes #4135
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: