Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to directly convert from integer and float to boolean #127

Merged
merged 3 commits into from
Nov 13, 2018

Conversation

BigYellowHammer
Copy link
Contributor

#73
#47

It was not possible to convert from int or float directly to boolean.
After those changes initial value still remains untouched.
Added few more tests and confirmed that behaviour for hashes didn't change.
In case of arrays - now arrays containing integers/floats can be converted to boolean arrays

@jsvd jsvd requested a review from guyboertje October 1, 2018 16:56
Copy link
Contributor

@guyboertje guyboertje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyboertje guyboertje merged commit 2df8f6d into logstash-plugins:master Nov 13, 2018
@synFK
Copy link

synFK commented Jan 4, 2019

Could you please update the plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants