support for DAV:status code and DAV:location, plus sync-collection fix #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix <DAV:sync-collection> in webdav.xsd by straightening out the property order, the allowable <DAV:sync-limit> values, and the syntax of the <DAV:limit> element. Update the JAXB model classes and our SyncCollectionReport object as appopriate.
RFC 4918 includes a "location" element in a <DAV:response>:
<!ELEMENT response (href, ((href*, status)|(propstat+)),
error?, responsedescription? , location?) >
<!ELEMENT location (href)>
Add support for an optional <DAV:location> element in a
<DAV:response> by updating webdav.xsd and generating new
Response and Location JAXB model classes. (We also update the
ObjectFactory, which is not currently auto-generated.)
Note that the location value is not currently exposed by
DavResource.
DAV resources may contain a <DAV:status> instead of a <DAV:propstat>. We parse these optional status lines and expose the status code (or 200 when absent) via DavResource.getStatusCode. A small code reorg moves the propstat properties as final members of an inner class.
|
Can you please rebase with the master branch which will also make the tests green. |
|
Replaced by pull request #241. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose DavResource's optional DAV:status value
DAV resources may contain a DAV:status instead of a DAV:propstat.
We parse these optional status lines and expose the status code
(or 200 when absent) via DavResource.getStatusCode.
A small code reorg moves the propstat properties as final members
of an inner class.
complete DAV:response by including DAV:location element
RFC 4918 includes a "location" element in a DAV:response:
minor fixes for the sync-collection report
Fix DAV:sync-collection in webdav.xsd by straightening out the
property order, the allowable DAV:sync-limit values, and the
syntax of the DAV:limit element. Update the JAXB model classes
and our SyncCollectionReport object as appopriate.