Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add glasses icon #149

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Conversation

ahtohbi4
Copy link
Contributor

@ahtohbi4 ahtohbi4 commented Dec 2, 2020

Icon glasses was added

Icon glasses

Copy link
Contributor

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this design, personnally.

@ericfennis
Copy link
Member

ericfennis commented Dec 3, 2020

@ahtohbi4 Maybe try one version for comparison with straight feet?

@ericfennis ericfennis added the 🎨 icon About new icons label Dec 20, 2020
@mittalyashu
Copy link
Member

The naming might be bit confusing.

Suggestions:

  1. Sun glasses
  2. Spectacles

@moeenio
Copy link
Contributor

moeenio commented Jan 15, 2021

Why would it be?

@mittalyashu
Copy link
Member

@locness3 the keyword "glass" can itself define lots of things.

CleanShot 2021-01-16 at 21 36 31@2x

you can mark this comment as off-topic, if you want

@moeenio
Copy link
Contributor

moeenio commented Jan 16, 2021

Yup but glasses (plural) generally means what you wear, and I wouldn't imagine to find an icon with multiple drkining glasses.

@ericfennis
Copy link
Member

What do you think of longer feet?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants