Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): always run script #825

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix(ios): always run script #825

merged 2 commits into from
Feb 6, 2025

Conversation

Gregoirevda
Copy link
Contributor

As the .env file could be anywhere (monorepo etc) specifying a specific .env file path won't work and knowing how important it is to have .env in sync, I think running this script on every build makes sense

Fixes issues 692 and 591

@Gregoirevda
Copy link
Contributor Author

Requires a pod install after the patch is applied and updates the flag

before
Screenshot 2024-12-13 at 10 08 51

after
Screenshot 2024-12-13 at 10 14 19

@Gregoirevda
Copy link
Contributor Author

@luancurti can you have a look please?

@matsola-preply
Copy link

@luancurti Could you check this PR?

Copy link
Collaborator

@luancurti luancurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Gregoirevda

@luancurti luancurti merged commit 8e7f7df into lugg:master Feb 6, 2025
@Gregoirevda
Copy link
Contributor Author

Also fixes issues #698 and #788
and PR's #801 #784

@luancurti Possible to publish a release please?

@luancurti
Copy link
Collaborator

Published on v1.5.5! 🎉

Thank you again. @Gregoirevda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants