Make description not mandatory on security definition #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, the open source change happened faster than this one so I will close as this is no longer blocking Viking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the description is mandatory for the security definition while the on the OpenAPI specification it is not.
I am currently using an open source project for generating the swagger spec from code, but it currently does not support description for the security definition and then the iOS app is failing to generate the stubs from the mentioned file.
I will for sure do a contribution to the open source library, but I cannot push them to release it soon.
EDIT: Added the PR for the open source library here
Disclaimer: I have a Windows machine and I don't know Swift, but maybe this is enough.