Don't allocate useless resources in single instance mode #389
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the single instance mode, the code initialized a window with its modules and made a useless signal-slot connection if screengrab was called while another instance was already running. Of course, they were all deleted instantly. The patch does the initialization only for the main instance.
|
@isf63 |
This was referenced Feb 21, 2025
|
Note: I do not use Screengrab as LXImage-Qt screenshot is fine for me. The multiple instances toggle indeed is wonky, ... The functionality itself remains the same on X11 as far as I can tell. |
It has no real use, but it works fine here, perhaps because I've applied another patch, which will be my next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the single instance mode, the code initialized a window with its modules and made a useless signal-slot connection if screengrab was called while another instance was already running. Of course, they were all deleted instantly.
The patch does the initialization only for the main instance.