forked from dotnet/maui
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gtk] implement date picke #284
Merged
lytico
merged 10 commits into
lytico/gtk-ongoing
from
lytico/issues/implement-datetimepicker
Mar 20, 2024
Merged
[Gtk] implement date picke #284
lytico
merged 10 commits into
lytico/gtk-ongoing
from
lytico/issues/implement-datetimepicker
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry pick from nblockchain@33aa7d6
Fix potential exception if DatePicker is used many times quickly: ``` (GWallet.Frontend.Maui:110296): GLib-GObject-CRITICAL **: 12:14:36.625: g_object_remove_toggle_ref: assertion 'G_IS_OBJECT (object)' failed (GWallet.Frontend.Maui:110296): GLib-GObject-CRITICAL **: 12:14:36.627: g_object_remove_toggle_ref: assertion 'G_IS_OBJECT (object)' failed Marshaling button-press-event signal Exception in Gtk# callback delegate Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception. GLib.MissingIntPtrCtorException: Unable to construct instance of type Microsoft.Maui.Platform.DatePickerWindow from native object handle. Instance of managed subclass may have been prematurely disposed. at GLib.ObjectManager.CreateObject(IntPtr raw) at GLib.Object.GetObject(IntPtr o, Boolean owned_ref) at GLib.Value.get_Val() at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) at GLib.ExceptionManager.RaiseUnhandledException(Exception e, Boolean is_terminal) at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) at GLib.Application.Run(String program_name, String[] args) at GLib.Application.Run() at Microsoft.Maui.MauiGtkApplication.Launch(EventArgs args) in /home/ubuntu/geewallet-build/geewallet/dependencies/maui/src/Core/src/Platform/Gtk/MauiGtkApplication.cs:line 127 at Microsoft.Maui.MauiGtkApplication.Run(String[] args) in /home/ubuntu/geewallet-build/geewallet/dependencies/maui/src/Core/src/Platform/Gtk/MauiGtkApplication.cs:line 40 at GWallet.Frontend.Maui.Program.main(String[] _args) in /home/ubuntu/geewallet-build/geewallet/src/GWallet.Frontend.Maui/Platforms/Gtk/Program.fs:line 14 ``` By using Hide instead of Destroy. (cherry picked from commit 7ff3c3a)
Fix position of calendar pop-up when opened more than one time. (cherry picked from commit 1dcf7a9)
Avoid excessive firing of OnDateTimeChanged events when creating DatePickerWindow. (cherry picked from commit a1efe23)
Update calendar properties SelectedDate, MinimumDate, MaximumDate when opening calendar popup when it is already created but hidden. (cherry picked from commit fe92c90)
DatePicker window location was wrong when we didn't use x11 GdkBackend. This problem was fixed by setting the TransientFor property. Co-authored-by: webwarrior-ws <[email protected]> (cherry picked from commit 0032339)
Replace deprecated methods. Used Entry icon instead of defining a new button for datepicker arrow. Co-authored-by: webwarrior-ws <[email protected]> (cherry picked from commit 8c3d7c2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
implement DatePicker
cherry picked from nblockchain#7
Issues Fixed
Fixes #