Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references #97

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Add references #97

merged 2 commits into from
Apr 12, 2023

Conversation

IamShubhamGupto
Copy link
Member

@IamShubhamGupto IamShubhamGupto commented Apr 12, 2023

To review

  • Should all blogs referenced also be in references or just links is fine?
  • All references are linked to correct papers

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@dhruvbalwada dhruvbalwada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve with the hope that everything renders properly on the website, as I don't have a way to check. The principle of it seems robust

@dhruvbalwada dhruvbalwada merged commit ecc0c71 into m2lines:main Apr 12, 2023
@dhruvbalwada
Copy link
Collaborator

@IamShubhamGupto
At the moment the references are rendering as: Lor95, Wil05 etc. (Not sure how these short hands are being decided).
However, when I look at jupyter book doc: https://jupyterbook.org/en/stable/tutorials/references.html it is showing much nicer looking references: Caporaso et al., 2010, Perez et al, 2019 etc.

Is it possible to adjust this format? The goal is to have references that are easily identifiable (not numbers or acronyms).

@IamShubhamGupto
Copy link
Member Author

@dhruvbalwada
Hey sure, even I noticed these shorthand citations. at least according to the above documentation, it should be fixed by changing the config file. Ill make a new PR for with that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants