Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainline/UCT-1023: Theme scanning feature #1029

Merged
merged 14 commits into from
Mar 17, 2022
Merged

Mainline/UCT-1023: Theme scanning feature #1029

merged 14 commits into from
Mar 17, 2022

Conversation

bohdan-harniuk
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk commented Mar 15, 2022 •
edited
Loading

Description (*)

Merge theme scanning feature to the develop branch.

Screenshot 2022-03-15 at 12 47 45

Screenshot 2022-03-15 at 12 37 13

Screenshot 2022-03-15 at 12 35 23

Fixed Issues (if relevant)

  1. Fixes [UCT] Cover themes scanning/reporting for the Tools > Run The Upgrade Compatibility Tool #1023

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

bohdan-harniuk and others added 11 commits March 4, 2022 11:51
@bohdan-harniuk
1023: initialized mainline branch
9b11abb
@doninAtwix
1023: Added additional fields for UCT configuration dialog
11606af
@doninAtwix
1023: update logic and code style
a17258a
@bohdan-harniuk
Merge pull request #1024 from doninAtwix/1023-add-configure-option
267b88c 
1023: Added an additional path field for UCT configuration dialog (to cover theme folder scanning)
@doninAtwix
1023: added functional for addtional scanning files
9e799ac
@bohdan-harniuk
1023: Removed unnecessary files
667f86b
@bohdan-harniuk
1023: Added support of the theme component
6228b90
@bohdan-harniuk
1023: Added phtml files support
6f24218
@bohdan-harniuk
Merge branch '4.3.0-develop' of github.com:magento/magento2-phpstorm-…
d1db080 
…plugin into 1023-add-additional-scanning
@bohdan-harniuk
1023: Added themes count into the json report
47d4cdc
@bohdan-harniuk
Merge pull request #1028 from doninAtwix/1023-add-additional-scanning
676c5d6 
1023: [UCT] Added theme scanning
@bohdan-harniuk bohdan-harniuk requested a review from Iamwade March 15, 2022 10:51
Iamwade
Iamwade approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@Iamwade Iamwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Approve.

@Iamwade Iamwade merged commit 3c6721b into 4.3.0-develop Mar 17, 2022
@VitaliyBoyko VitaliyBoyko deleted the mainline/uct-1023-theme-scanning-feature branch December 16, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iamwade Iamwade Iamwade approved these changes

Assignees

@bohdan-harniuk bohdan-harniuk

@Iamwade Iamwade

Labels
Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UCT] Cover themes scanning/reporting for the Tools > Run The Upgrade Compatibility Tool
3 participants
@bohdan-harniuk @Iamwade @doninAtwix