Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add search functionality to macro settings interface #2141

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mnigbur
Copy link
Contributor

@mnigbur mnigbur commented Feb 9, 2025

Description

This PR adds search functionality to the macro settings interface

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

none

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Language file analysis report:

File Missing Keys Unused Keys
cz.json 349 23
da.json 54 12
de.json 1 0
en.json 0 0
es.json 24 21
fr.json 202 15
hu.json 25 24
it.json 22 3
ja.json 350 22
ko.json 346 22
nl.json 280 22
pl.json 230 13
pt.json 323 21
ru.json 0 0
se.json 200 14
tr.json 277 19
uk.json 61 5
zh.json 1 1
zh_TW.json 342 21

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Language file analysis report:

File Missing Keys Unused Keys
cz.json 348 22
da.json 54 12
de.json 1 0
en.json 0 0
es.json 24 21
fr.json 202 15
hu.json 25 24
it.json 22 3
ja.json 350 22
ko.json 346 22
nl.json 280 22
pl.json 230 13
pt.json 323 21
ru.json 0 0
se.json 200 14
tr.json 277 19
uk.json 61 5
zh.json 1 1
zh_TW.json 342 21

@meteyou
Copy link
Member

meteyou commented Feb 9, 2025

@mnigbur thx for this PR!

are you a native speaker in all these languages? normally we only add english and our native language (in my case germany). all other languages should be added by the translators.

Could you also change the layout of the search field? for example like this in the gcode file panel:
image

so it should not be the same "style/layout" as the normal "input fields for settings".

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 12, 2025
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
cz.json 348 22
da.json 54 12
de.json 1 0
en.json 0 0
es.json 24 21
fr.json 202 15
hu.json 25 24
it.json 22 3
ja.json 350 22
ko.json 346 22
nl.json 280 22
pl.json 230 13
pt.json 323 21
ru.json 0 0
se.json 200 14
tr.json 277 19
uk.json 61 5
zh.json 1 1
zh_TW.json 342 21

@mnigbur
Copy link
Contributor Author

mnigbur commented Feb 13, 2025

@mnigbur thx for this PR!

are you a native speaker in all these languages? normally we only add english and our native language (in my case germany). all other languages should be added by the translators.

Could you also change the layout of the search field? for example like this in the gcode file panel: image

so it should not be the same "style/layout" as the normal "input fields for settings".

@meteyou
The translation for "search" already existed for all languages, so i prefilled it for all of them.
What's the issue with prettier? I did run the script before committing. CLRF issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants