Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed time string formatter in ISOFormatter #628

Merged
merged 2 commits into from
Jan 20, 2019
Merged

Fixed time string formatter in ISOFormatter #628

merged 2 commits into from
Jan 20, 2019

Conversation

TeunVR
Copy link

@TeunVR TeunVR commented Dec 13, 2018

Otherwise time-string looks like: "2018-12-1213:49:25" instead of "2018-12-12T13:49:25"

Also add separator for withTime option.
e9ffba7 
Otherwise time-string looks like: "2018-12-1213:49:25" instead of "2018-12-12T13:49:25"
@malcommac malcommac changed the base branch from develop to feature/5.1.0 January 20, 2019 09:03
@malcommac malcommac added this to the 5.1.0 milestone Jan 20, 2019
@malcommac malcommac added the bug label Jan 20, 2019
@malcommac malcommac self-requested a review January 20, 2019 09:04
@malcommac malcommac self-assigned this Jan 20, 2019
@malcommac malcommac changed the title Also add separator for withTime option. Fixed time string formatter in ISOFormatter Jan 20, 2019
@malcommac malcommac merged commit 2eea6f8 into malcommac:feature/5.1.0 Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcommac malcommac Awaiting requested review from malcommac

Assignees

@malcommac malcommac

Labels
bug
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TeunVR @malcommac