disable emboss filter (#308) because it looks bad with transparency

debian/changelog

@@ -3,7 +3,6 @@ drawing (0.8.0) unstable; urgency=low
   * brush supporting pressure-sensitive input (#69, #116)
   * improve the fullscreen mode, with a way to toggle the tools list (#265, #189)
   * add an "increase constrast" filter (#308)
-  * add a basic "emboss" filter (#308)
   * remove the cool but deprecated GNOME Shell app menu
   * deleting the selection can now leave something else than transparency #232
   * exclude the color left under the selection from the selection itself #232

src/printing_manager.py

@@ -71,6 +71,12 @@ def _do_begin_print(self, op, print_ctx, pixbuf):
 		op.set_n_pages(1)
 		self._show_pixbuf_on_page(print_ctx, pixbuf)
 
+	# The typical way to use the high-level printing API is to create a
+	# Gtk.PrintOperation object with Gtk.PrintOperation.new() when the user
+	# selects to print. Then you set some properties on it, e.g. the page size,
+	# any Gtk.PrintSettings from previous print operations, the number of pages,
+	# the current page, etc.
+	#
 	# XXX là je ne restaure aucun PrintSettings ce qui est un problème
 
 	def _show_pixbuf_on_page(self, print_ctx, pixbuf):

src/tools/transform_tools/tool_filters.py

@@ -40,7 +40,7 @@ def __init__(self, window):
 		self.type_label = _("Change saturation")
 		self._active_filter = 'saturation'
 
-		# Options specific to filters but which are here for no good reason
+		# Options specific to filters, but which are here for no good reason
 		self.add_tool_action_enum('filters_blur_dir', 'none')
 		self.blur_algo = BlurType.INVALID
 
@@ -119,6 +119,7 @@ def _set_active_type(self, *args):
 			self._active_filter = 'contrast'
 		# TODO changer la luminosity tant qu'à faire
 		elif state_as_string == 'emboss':
+			# Context: a filter. See "image embossing" on wikipedia
 			self.type_label = _("Emboss")
 			self._active_filter = 'emboss'
 

src/tools/ui/tool-filters.ui

@@ -24,19 +24,18 @@
             <attribute name="action">win.filters_type</attribute>
             <attribute name="target">transparency</attribute>
           </item>
-        </section>
-        <section>
+        <!-- </section> -->
+        <!-- <section> -->
           <item>
             <attribute name="label" translatable="yes">Increase contrast</attribute>
             <attribute name="action">win.filters_type</attribute>
             <attribute name="target">contrast</attribute>
           </item>
-          <item>
-            <!-- Context: a filter. See "image embossing" on wikipedia -->
-            <attribute name="label" translatable="yes">Emboss</attribute>
-            <attribute name="action">win.filters_type</attribute>
-            <attribute name="target">emboss</attribute>
-          </item>
+          <!-- <item> -->
+          <!--   <attribute name="label" translatable="yes">Emboss</attribute> -->
+          <!--   <attribute name="action">win.filters_type</attribute> -->
+          <!--   <attribute name="target">emboss</attribute> -->
+          <!-- </item> -->
         </section>
         <section>
           <!-- Context: the title of the menu with various types of blurring -->

src/window.py

@@ -312,7 +312,7 @@ def on_active_tab_changed(self, *args):
 		self.set_picture_title(args[1].update_title())
 		self.minimap.set_zoom_label(args[1].zoom_level * 100)
 		args[1].update_history_sensitivity()
-		# On devrait être moins bourrin et conserver la sélection # TODO
+		# On devrait être moins bourrin et conserver la sélection # TODO ?
 
 	def update_tabs_menu_section(self, *args):
 		action = self.lookup_action('active_tab')