Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the eraser tool into 3 possible implementations #503

Closed
9 tasks done
maoschanz opened this issue Mar 31, 2022 · 0 comments
Closed
9 tasks done

Refactor the eraser tool into 3 possible implementations #503

maoschanz opened this issue Mar 31, 2022 · 0 comments
Labels
enhancement ideas to improve existing features tools bugs or suggestions related to tools
Milestone

Comments

@maoschanz
Copy link
Owner

maoschanz commented Mar 31, 2022

Use case

While the "fill"/"paint bucket" feature still sucks, its "remove color" option works very well, and is soooooo useful to cut out a background

It would be more intuitive and accessible to list that option in the eraser instead

Suggested solution

  • On the same model as brushes, split the eraser into several files
    • the current one
    • an abstract thing
    • its "pencil" implementation
    • its "rectangle" implementation
  • persist the value of the last used eraser mode
  • Add the "remove color" implementation
    • in the UI ("magic" icon)
    • re-implement the existing behavior, using the color at the "release" signal
    • improvement: use a list of RGBs along the path of the pointer instead
  • remove the feature from the "paint" tool

Possible drawbacks

The behavior of the #46 regarding the tool has to change, or to disappear

Possible alternatives

Distinct tools, but they might be too specialized?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ideas to improve existing features tools bugs or suggestions related to tools
Projects
None yet
Development

No branches or pull requests

1 participant