Added projection unit tests #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ struct Options { | |||
| const Tile empty_tile{}; | |||
|
|
|||
| inline uint64_t toID(uint8_t z, uint32_t x, uint32_t y) { | |||
| return (((1 << z) * y + x) * 32) + z; | |||
| return (((1ull << z) * y + x) * 32) + z; | |||
There was a problem hiding this comment.
what's the difference between 1ull and 1u and why would we use both?
There was a problem hiding this comment.
ull stands for unsigned long long (usually 64-bit) and u is simply unsigned(usually 32-bit). These are used to tell the compiler we want those numbers to be contained in types that can hold them. In this specific case we use 64-bits because we return a uint64_t type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin-off from debugging mapbox/mapbox-gl-native#5505.
👀 @yhahn @mourner @kkaefer @jfirebaugh