Add AudioType Support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add AudioTypeResolver - add specific audio types - add AudioTypeChain - integrate into MapboxTelemetry
electrostat
force-pushed
the
aa-audio-type-support
branch
from
7e8722e to
f48217e
Compare
Guardiola31337
requested changes
Nov 20, 2017
| @@ -0,0 +1,16 @@ | |||
| package com.mapbox.services.android.telemetry.audio; | |||
|
|
|||
| public class AudioTypeChain { | |||
There was a problem hiding this comment.
Why is this public?
|
|
||
| public class AudioTypeChain { | ||
|
|
||
| public AudioTypeResolver setup() { |
|
|
||
| import android.content.Context; | ||
|
|
||
| public interface AudioTypeResolver { |
There was a problem hiding this comment.
Why is this public?
| import android.content.Context; | ||
| import android.media.AudioManager; | ||
|
|
||
| public class HeadphonesAudioType implements AudioTypeResolver { |
There was a problem hiding this comment.
Why is this public?
| import android.content.Context; | ||
| import android.media.AudioManager; | ||
|
|
||
| public class SpeakerAudioType implements AudioTypeResolver { |
There was a problem hiding this comment.
Why is this public?
|
|
||
| import android.content.Context; | ||
|
|
||
| public class UnknownAudioType implements AudioTypeResolver { |
There was a problem hiding this comment.
Why is this public?
| @@ -277,4 +280,11 @@ public void onServiceDisconnected(ComponentName className) { | |||
| serviceBound = false; | |||
| } | |||
| }; | |||
|
|
|||
| public String obtainAudioType() { | |||
There was a problem hiding this comment.
Where are we using obtainAudioType()? MapboxTelemetry shouldn't expose this functionality. obtainAudioType() should live in another class in which has more context of what it's doing. Events?
- create NavigationUtils - return audiotype there to dev - refactor audio classes out of their own directory, for later refactoring (likely into own Navigation directory)
Guardiola31337
approved these changes
Nov 21, 2017
electrostat
added a commit
that referenced
this pull request
Dec 13, 2017
* Add AudioType Support * NavigationUtils + Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds audioType support with a chain of responsibility of:
speaker>bluetooth>headphones>unknown