Add null checks for obtainSharedPreferences #202

electrostat · 2018-08-28T21:03:12Z

Add null checks within parent methods for obtainSharedPreferences

- add null checks - pass along default values for parent methods to `obtainSharedPreferences`

- switch logic of methods to be more efficient and readable

Guardiola31337

Wondering if returning "hardcoded" states when MapboxTelemetry.applicationContext is null could affect the overall behavior somehow. Especially after, when the app is restarted 🤔 Have we thought about that?

Guardiola31337 · 2018-08-30T07:46:19Z

libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryUtils.java

@@ -177,6 +177,10 @@ static boolean isEmpty(String string) {
  }

  static String retrieveVendorId() {
+    if (MapboxTelemetry.applicationContext == null) {
+      return updateVendorId();


Have we considered returning obtainUniversalUniqueIdentifier() here? Doing so, would remove the need for

mapbox-events-android/libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryUtils.java

Lines 199 to 203 in 329a1d6

String uniqueId = obtainUniversalUniqueIdentifier();

if (MapboxTelemetry.applicationContext == null) {

return uniqueId;

}

in updateVendorId() 👇

null checks for obtainSharedPreferences

4417408

- add null checks - pass along default values for parent methods to `obtainSharedPreferences`

electrostat added the bug label Aug 28, 2018

electrostat self-assigned this Aug 28, 2018

electrostat mentioned this pull request Aug 28, 2018

App crashes because of NPE in TelemetryUtils mapbox/mapbox-gl-native#12748

Closed

Flip Logic

329a1d6

- switch logic of methods to be more efficient and readable

electrostat requested review from andrlee and zugaldia August 28, 2018 22:10

andrlee approved these changes Aug 29, 2018

View reviewed changes

electrostat merged commit 6fa3ce7 into master Aug 29, 2018

electrostat deleted the aa-obtainsharedprefs-null-check branch August 29, 2018 15:29

Guardiola31337 reviewed Aug 30, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add null checks for obtainSharedPreferences #202

Add null checks for obtainSharedPreferences #202

electrostat commented Aug 28, 2018

Guardiola31337 left a comment

Guardiola31337 Aug 30, 2018

	String uniqueId = obtainUniversalUniqueIdentifier();

	if (MapboxTelemetry.applicationContext == null) {
	return uniqueId;
	}

Add null checks for obtainSharedPreferences #202

Add null checks for obtainSharedPreferences #202

Conversation

electrostat commented Aug 28, 2018

Guardiola31337 left a comment

Choose a reason for hiding this comment

Guardiola31337 Aug 30, 2018

Choose a reason for hiding this comment