ACCESS_FINE_LOCATION permission exception #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check if ACCESS_FINE_LOCATION permission is a part of the manifest - throw exception to alert developer to cause of crash - waiting on feedback to prevent crash or keep it (small change)
andrlee
suggested changes
Oct 3, 2018
libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryService.java
Outdated
Show resolved
Hide resolved
- prevent creation of passive provider, when pre-6.0 and no Fine location permission available
andrlee
suggested changes
Oct 3, 2018
| private boolean checkFinePermission(int finePermission) { | ||
| if (finePermission != PackageManager.PERMISSION_GRANTED) { | ||
| try { | ||
| throw new Exception(MISSING_FINE_PERMISSION); |
There was a problem hiding this comment.
i'm still not sure why we need to throw exception catch and handle it in the same method? since we're basically stuck with passive provider would it make sense just to check if fine permissions are granted and if not let the user know that we can't collect location preferably via SecurityException? Thoughts?
- replace exception with a debug log, to remove try/catch and still inform dev/us of missing permission - reworded debug message
andrlee
reviewed
Oct 4, 2018
| if (checkFinePermission(finePermission)) { | ||
| return false; | ||
| } | ||
|
|
||
| return coarsePermission == PackageManager.PERMISSION_GRANTED |
There was a problem hiding this comment.
does it actually make sense to check for coarse permission with passive provider at all?
- remove the coarse location permission - rework `checkFinePermission` to send back appropriate bool and display message at correct time.
andrlee
approved these changes
Oct 5, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect if
ACCESS_FINE_LOCATIONpermission has been removed from the manifest and throw an exception.Fixes #222