Fix crash due to null context reference in LocationBroadcastReceiver #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crashes and introduce temporary refactor for
TelemetryUtils
class until libtelemetry is fully rewritten.Although this change is backwards compatible, it impacts @mapbox/navigation-android. Specifically,
NavigationState
class, which public constructor became deprecated.the new recommended way of instantiating this class is via this static factory:
The motivation behind this change is extracting
Context
as much as possible from utility class. What it means for navigation sdk: if switch from public constructor to static factory is not happening, we will be loosing all device info fields, such asplugged
,networkType
and etc.@Guardiola31337 @danesfeder please let me know if i need to create a ticket in android nav repo to track this change.
Stack trace of this crash: