-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Unused Lifecycle Dependencies #331
Conversation
- exlude dependencies that are not used within the sdk
-include android.arch.core:common dependency
- include runtime dependency
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=========================================
Coverage 52.97% 52.97%
Complexity 522 522
=========================================
Files 103 103
Lines 3392 3392
Branches 228 228
=========================================
Hits 1797 1797
Misses 1491 1491
Partials 104 104 |
what about:
|
- exclude support-annotations from lifecycle extensions
Removed all unused dependencies from within +--- android.arch.lifecycle:extensions:1.1.0 cc: @andrlee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please test this with at least maps sdk before we merge to make sure there's no surprises? it'll also work if we merge and test a snapshot.
- support-annotations does not need to be removed, already included in earlier dependency
Exclude unused dependencies associated with
LifecycleExtensions
.Addresses: #273