Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Lifecycle Dependencies #331

Merged
merged 5 commits into from
Jan 28, 2019
Merged

Conversation

electrostat
Copy link
Contributor

@electrostat electrostat commented Jan 23, 2019

Exclude unused dependencies associated with LifecycleExtensions.

Addresses: #273

- exlude dependencies that are not used within the sdk
-include android.arch.core:common dependency
- include runtime dependency
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #331   +/-   ##
=========================================
  Coverage     52.97%   52.97%           
  Complexity      522      522           
=========================================
  Files           103      103           
  Lines          3392     3392           
  Branches        228      228           
=========================================
  Hits           1797     1797           
  Misses         1491     1491           
  Partials        104      104

@electrostat electrostat requested review from andrlee and tobrun January 23, 2019 20:43
@andrlee
Copy link
Contributor

andrlee commented Jan 23, 2019

what about:

+--- com.android.support:support-fragment:26.1.0
|    |    +--- com.android.support:support-compat:26.1.0
|    |    |    \--- com.android.support:support-annotations:26.1.0 -> 28.0.0
|    |    +--- com.android.support:support-core-ui:26.1.0
|    |    |    +--- com.android.support:support-annotations:26.1.0 -> 28.0.0
|    |    |    \--- com.android.support:support-compat:26.1.0 (*)
|    |    \--- com.android.support:support-core-utils:26.1.0
|    |         +--- com.android.support:support-annotations:26.1.0 -> 28.0.0
|    |         \--- com.android.support:support-compat:26.1.0 (*)

- exclude support-annotations from lifecycle extensions
@electrostat
Copy link
Contributor Author

Removed all unused dependencies from within support-fragment. Here is what the tree looks like for lifecycle extensions:

+--- android.arch.lifecycle:extensions:1.1.0
| +--- android.arch.lifecycle:runtime:1.1.0
| | +--- android.arch.lifecycle:common:1.1.0
| | --- android.arch.core:common:1.1.0
| +--- android.arch.core:common:1.1.0
| +--- com.android.support:support-fragment:26.1.0
| | +--- com.android.support:support-compat:26.1.0
| | +--- com.android.support:support-core-ui:26.1.0
| | | --- com.android.support:support-compat:26.1.0
| | --- com.android.support:support-core-utils:26.1.0
| | --- com.android.support:support-compat:26.1.0
| --- android.arch.lifecycle:common:1.1.0

cc: @andrlee

Copy link
Contributor

@andrlee andrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please test this with at least maps sdk before we merge to make sure there's no surprises? it'll also work if we merge and test a snapshot.

- support-annotations does not need to be removed, already included in earlier dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants