Run liblocation test in CI #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaoba
force-pushed
the
liblocation_test
branch
3 times, most recently
from
465ff64 to
fee3455
Compare
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
============================================
+ Coverage 53.42% 54.99% +1.56%
Complexity 493 493
============================================
Files 106 106
Lines 3266 3266
Branches 219 219
============================================
+ Hits 1745 1796 +51
+ Misses 1435 1384 -51
Partials 86 86 |
Chaoba
force-pushed
the
liblocation_test
branch
4 times, most recently
from
f47417b to
e446058
Compare
andrlee
reviewed
Feb 14, 2019
...c/androidTest/java/com/mapbox/android/core/location/FusedLocationEngineInstrumentedTest.java
Outdated
Show resolved
Hide resolved
andrlee
reviewed
Feb 14, 2019
|
|
||
| } | ||
|
|
||
| private static LocationEngineRequest getRequest(long interval, int priority) { |
There was a problem hiding this comment.
can we cover intervals, fastest intervals, max wait time with integration tests?
There was a problem hiding this comment.
These params are handled by android framework, so IMHO we don't need to test these.
There was a problem hiding this comment.
@Chaoba the location engines that we support are not in complete feature parity, hence not all configs are seamlessly handled by framework. a good example is fastest interval: MapboxFusedLocationEngine doesn't support it: #312. Would be nice if we could create a test to cover all basic supported configs and verify expected behavior for future reference just in case someone decides to implement a new engine. Does that make sense?
andrlee
reviewed
Feb 14, 2019
.../androidTest/java/com/mapbox/android/core/location/GoogleLocationEngineInstrumentedTest.java
Outdated
Show resolved
Hide resolved
Chaoba
force-pushed
the
liblocation_test
branch
from
e446058 to
2421972
Compare
Chaoba
force-pushed
the
liblocation_test
branch
from
2421972 to
d48bc5e
Compare
Chaoba
force-pushed
the
liblocation_test
branch
from
d48bc5e to
c0cbd42
Compare
andrlee
reviewed
Feb 19, 2019
liblocation/src/main/java/com/mapbox/android/core/location/GoogleLocationEngineImpl.java
Outdated
Show resolved
Hide resolved
Chaoba
force-pushed
the
liblocation_test
branch
from
4be77c6 to
7959683
Compare
andrlee
reviewed
Feb 19, 2019
liblocation/src/main/java/com/mapbox/android/core/location/GoogleLocationEngineImpl.java
Outdated
Show resolved
Hide resolved
andrlee
reviewed
Feb 19, 2019
liblocation/src/test/java/com/mapbox/android/core/location/GoogleLocationEngineImplTest2.java
Outdated
Show resolved
Hide resolved
andrlee
reviewed
Feb 19, 2019
liblocation/src/test/java/com/mapbox/android/core/location/GoogleLocationEngineImplTest2.java
Outdated
Show resolved
Hide resolved
andrlee
reviewed
Feb 19, 2019
|
@andrlee All fixed now. |
andrlee
reviewed
Feb 20, 2019
|
|
||
| @RunWith(AndroidJUnit4.class) | ||
| public class LocationEngineInstrumentedTest { | ||
| private static final long INTERVAL = 1000L; | ||
| private static final long INTERVAL = 100L; |
There was a problem hiding this comment.
why 100ms interval? is it typo?
andrlee
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
liblocationandroid instrumentation tests are not running as part of pre-commit tests, this PR will add them to CI and run on firebase.What's more, rewrite test cases with mock.