Refactor event queuing logic #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix instrumentations test time out for LocationEngine test.
Chaoba
force-pushed
the
al-fix-queue-race
branch
from
d6d8700 to
8f9a890
Compare
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 54.99% 54.8% -0.2%
+ Complexity 493 488 -5
==========================================
Files 106 103 -3
Lines 3266 3250 -16
Branches 219 217 -2
==========================================
- Hits 1796 1781 -15
+ Misses 1384 1383 -1
Partials 86 86 |
andrlee
force-pushed
the
al-fix-queue-race
branch
from
97b4f50 to
e079099
Compare
alfwatt
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor event queuing logic to address potential races with event queue: #342
Add more error handling and remove layers of redundant callback wrappers and simplifying internal housekeeping. Re-write unit tests and make them more DRY.
/cc @Guardiola31337 @angelanavarro