Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict mode #347

Merged
merged 16 commits into from
Mar 8, 2019
Merged

Add strict mode #347

merged 16 commits into from
Mar 8, 2019

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Feb 26, 2019

This PR adds enhancements to the internal test app that we could run pre-release to make sure we're not leaking perf regressions into production. Specifically:

  • Leak Canary was added for memory leak detection
  • Strict mode added to detect memory and threading issues
  • Test app functionality expanded into testing sdk in the worst possible scenarios: all public apis are called from the main thread
  • Fixes for potential perf regressions (which still aren't released into prod)

@Chaoba Chaoba self-assigned this Feb 26, 2019
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #347 into master will increase coverage by 0.28%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #347      +/-   ##
============================================
+ Coverage     56.73%   57.02%   +0.28%     
+ Complexity      491      488       -3     
============================================
  Files           102      101       -1     
  Lines          3190     3153      -37     
  Branches        219      215       -4     
============================================
- Hits           1810     1798      -12     
+ Misses         1293     1268      -25     
  Partials         87       87

@Chaoba Chaoba force-pushed the kl_strict_mode branch 6 times, most recently from 31caf3a to eeedd98 Compare March 5, 2019 09:00
@andrlee andrlee mentioned this pull request Mar 8, 2019
@andrlee andrlee merged commit 4af4bd5 into master Mar 8, 2019
@andrlee andrlee deleted the kl_strict_mode branch March 28, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants