-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strict mode #347
Merged
Merged
Add strict mode #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
============================================
+ Coverage 56.73% 57.02% +0.28%
+ Complexity 491 488 -3
============================================
Files 102 101 -1
Lines 3190 3153 -37
Branches 219 215 -4
============================================
- Hits 1810 1798 -12
+ Misses 1293 1268 -25
Partials 87 87 |
31caf3a
to
eeedd98
Compare
Reverting original changes since all strict mode violations were fixed by telemetry service refactor work.
Potential shared prefs access. on main thread
Closed
andrlee
approved these changes
Mar 8, 2019
This was referenced Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enhancements to the internal test app that we could run pre-release to make sure we're not leaking perf regressions into production. Specifically: