Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GoogleLocationEngine intermittent delayed updates #350

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

andrlee
Copy link
Contributor

@andrlee andrlee commented Feb 26, 2019

Reset default displacement value to 0 due to potential delay with first location update on Pie that takes 30 seconds - 1 min. We've not seen this behavior on pre-Pie api versions, so the assumption is that changes in framework were made that no longer work well with default displacement value we had tested with previously.

/cc @danesfeder @Guardiola31337

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #350   +/-   ##
=========================================
  Coverage     54.81%   54.81%           
  Complexity      488      488           
=========================================
  Files           103      103           
  Lines          3247     3247           
  Branches        217      217           
=========================================
  Hits           1780     1780           
  Misses         1380     1380           
  Partials         87       87

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick 👀 here @andrlee

In order to confirm that this was the issue causing the lag, would it make sense trying to reproduce #348 setting the displacement to 3.0f in the snippet that seems fixing it (FusedLocationEngine mapbox/mapbox-navigation-android#1764 (comment))?

In any case, this looks good to me 👍

@andrlee
Copy link
Contributor Author

andrlee commented Feb 27, 2019

@Guardiola31337 i was not able to repro this on emulator running Pie and i don't have hardware with Pie installed at hand. I asked @electrostat to help with testing though. May i suggest something? Can you ask your customers who have reported this to explicitly setDisplacement to 0 in their LocationEngineRequest object and retest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants