Add version to location collector userAgent #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
- Coverage 57.02% 57% -0.02%
Complexity 488 488
==========================================
Files 101 101
Lines 3153 3154 +1
Branches 215 215
==========================================
Hits 1798 1798
- Misses 1268 1269 +1
Partials 87 87 |
electrostat
approved these changes
Mar 14, 2019
|
yeah, i consider it a trivial change, when no existing or new functionality was changed or added, so ignoring codecov warning in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version number to the
userAgentfield of location collector. DefaultuserAgent: mapbox-android-location/x.x.x