Apply android-sdk-versions-plugin to Telemetry and Core modules #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add generated files to git. Write tests to ensute the files generated have appropriate information.
nkukday
reviewed
Nov 15, 2019
nkukday
reviewed
Nov 15, 2019
| public void testPersistedCoreSDKInfo() { | ||
| Context context = InstrumentationRegistry.getTargetContext(); | ||
| AssetManager assetManager = context.getAssets(); | ||
| InputStream is = null; |
There was a problem hiding this comment.
is could use a more meaningful name
nkukday
reviewed
Nov 15, 2019
libcore/src/androidTest/java/com/mapbox/android/core/CoreSDKVersionTest.java
Outdated
Show resolved
Hide resolved
nkukday
reviewed
Nov 15, 2019
nkukday
reviewed
Nov 15, 2019
| public void testPersistedTelemetrySDKInfo() { | ||
| Context context = InstrumentationRegistry.getTargetContext(); | ||
| AssetManager assetManager = context.getAssets(); | ||
| InputStream is = null; |
nkukday
reviewed
Nov 15, 2019
libtelemetry/src/androidTest/java/com/mapbox/android/telemetry/TelemetrySDKVersionTest.java
Outdated
Show resolved
Hide resolved
nkukday
reviewed
Nov 15, 2019
libcore/src/androidTest/java/com/mapbox/android/core/CoreSDKVersionTest.java
Outdated
Show resolved
Hide resolved
harvsu
force-pushed
the
apply-versions-plugin
branch
from
11cbde4 to
f5471c8
Compare
nkukday
approved these changes
Nov 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
============================================
- Coverage 68.25% 68.23% -0.02%
- Complexity 382 383 +1
============================================
Files 68 68
Lines 2079 2084 +5
Branches 163 163
============================================
+ Hits 1419 1422 +3
- Misses 570 571 +1
- Partials 90 91 +1 |
This was referenced Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin https://github.com/mapbox/android-sdk-versions-plugin validates and persists the SDK version into a file in assets folder. This information further feeds into Reformed User Agent.
https://github.com/mapbox/mobile-telemetry/issues/452
https://github.com/mapbox/mobile-telemetry/issues/423