Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version to >=10 #445

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Update Node version to >=10 #445

merged 1 commit into from
Dec 11, 2019

Conversation

harvsu
Copy link
Contributor

@harvsu harvsu commented Dec 11, 2019

Node 8 gets to EOL in Dec 2019. It is recommended to update to the latest node version as mentioned here:
https://github.com/mapbox/telemetry/issues/572

@harvsu harvsu requested review from alfwatt and nkukday December 11, 2019 22:21
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #445 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #445      +/-   ##
============================================
+ Coverage     68.56%   68.65%   +0.09%     
- Complexity      393      394       +1     
============================================
  Files            69       69              
  Lines          2144     2144              
  Branches        171      171              
============================================
+ Hits           1470     1472       +2     
+ Misses          576      575       -1     
+ Partials         98       97       -1

Update version to 4.7.1 in package.json
@harvsu harvsu force-pushed the update-node-version branch from b8eb295 to b918def Compare December 11, 2019 22:37
@@ -1,6 +1,6 @@
{
"name": "@mapbox/mapbox-events-android",
"version": "4.0.0",
"version": "4.7.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.7.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.7.0 release is already done. Whatever merged to master from now on will be snapshotted at 4.7.1. So, I made this version to be in sync with current telemetry version.

@harvsu harvsu merged commit 39a3e65 into master Dec 11, 2019
Copy link

@alfwatt alfwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

harvsu pushed a commit that referenced this pull request Mar 12, 2020
harvsu pushed a commit that referenced this pull request Mar 16, 2020
harvsu pushed a commit that referenced this pull request Mar 16, 2020
Set version in gradle.properties .
Replace master with long-term-support in config.yml .
harvsu pushed a commit that referenced this pull request Mar 17, 2020
harvsu added a commit that referenced this pull request Mar 17, 2020
Update version to 4.7.1 in package.json
harvsu added a commit that referenced this pull request Mar 17, 2020
harvsu added a commit that referenced this pull request Mar 17, 2020
Update version to 4.7.1 in package.json
harvsu added a commit that referenced this pull request Mar 18, 2020
* Update Changelog.md for release Core 1.4.0 / Telemetry 4.7.0(#440)

* Update Gradle Versions: (#444)

Gradle Version : 5.6.4
Android Gradle Plugin Version : 3.5.3

* Update Node version to >=10 in package.json (#445)

Update version to 4.7.1 in package.json

* Workaround for Strict mode socket issue: (#443)

Add custom socket factory and set TrafficStats.setThreadStatsTag(1000) for configuration client(okhttpClient).

* Fix Turnstile Obfuscation (#457)

* Fix obfuscation:

Prevent obfuscation of Event classes to keep properties in JSON schema unaltered.
Throw Assertion Error in Test App in case of POST failure for an event.
Set minifyEnabled true in build.gradle for debug build to make the test
app behave close to production app.
Add button on test app's main screen, which sends turnstile event on click.
Add @SerializedName annotation to Turnstile and Crash Event properties
to keep them consistent with other events.
Fix Location Schema test to ignore the properties(speed, course, floor,
speedAccuracy, courseAccuracy, and verticalAccuracy) that are
added in the backend but not incorporated into the SDK yet!

* Update Config.yml to indicate long-term-support as pseudo master branch.
Append -lts to name of the binary while publishing the binary size.
Update Version in gradle.properties and package.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants