Modify error reporting for API >= 26 #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
============================================
- Coverage 68.41% 68.26% -0.16%
- Complexity 394 397 +3
============================================
Files 69 70 +1
Lines 2159 2174 +15
Branches 172 172
============================================
+ Hits 1477 1484 +7
- Misses 584 591 +7
- Partials 98 99 +1 |
alfwatt
approved these changes
Apr 7, 2020
libtelemetry/src/full/java/com/mapbox/android/telemetry/MapboxTelemetry.java
Show resolved
Hide resolved
libtelemetry/src/full/java/com/mapbox/android/telemetry/crash/CrashReporter.java
Outdated
Show resolved
Hide resolved
libtelemetry/src/full/java/com/mapbox/android/telemetry/crash/CrashReporter.java
Outdated
Show resolved
Hide resolved
| crashReporter.sendErrorReports(); | ||
| } | ||
| }); | ||
| } catch (Throwable throwable) { |
There was a problem hiding this comment.
Might deserve a note that you are catching Throwable because we don't want the crash reporter to report it's own reporting errors:
|
@Guardiola31337 @pengdev I'd love your reviews from the Nav and Maps SDK sides, respectively. |
pengdev
approved these changes
Apr 9, 2020
| * This is a background job that sends crash events to the telemetry endpoint | ||
| * at startup. | ||
| */ | ||
| public final class CrashReporterJobIntentService extends JobIntentService { |
There was a problem hiding this comment.
Noting that this is technically breaking SemVer as it's a public class which is not under internal
There was a problem hiding this comment.
@nkukday though they arrived after merging the PR - did you have a chance to address @Guardiola31337's comments, maybe as tail work?
| @@ -1,4 +1,4 @@ | |||
| package com.mapbox.android.telemetry.crash; | |||
There was a problem hiding this comment.
Noting that this is technically breaking Semver as packages of a public class changed
harvsu
pushed a commit
that referenced
this pull request
Apr 21, 2020
# Resolve Conflicts: # libtelemetry/src/androidTestFull/java/com/mapbox/android/telemetry/errors/ErrorReporterEngineInstrumentedTest.java # libtelemetry/src/full/java/com/mapbox/android/telemetry/MapboxTelemetry.java # libtelemetry/src/full/java/com/mapbox/android/telemetry/crash/CrashReporterJobIntentService.java
harvsu
pushed a commit
that referenced
this pull request
Apr 21, 2020
harvsu
pushed a commit
that referenced
this pull request
Apr 21, 2020
harvsu
added a commit
that referenced
this pull request
Apr 21, 2020
* Handle null input while creating LocationEngineResult (#469) # Resolve Conflicts: # liblocation/src/main/java/com/mapbox/android/core/location/LocationEngineResult.java * Modify error reporting for API >= 26 (#472) Co-authored-by: Neeraja Kukday <[email protected]>
harvsu
pushed a commit
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing crashes within
JobIntentServiceon and above API 26. Linking the Google issue here. As a workaround, we will continue to useJobIntentServicebelow API 26 (Android O) and use a network request to report errors on or above API 26.