Fix a crash on newer android OS due to a depreacted API usage

[nagineni]

TelephonyManager.getNetworkType() is deprecated in API level 30, so
using getDataNetworkType() to get the current data network type on
newer android OS.

Co-authored-by: Tobrun Van Nuland [email protected]

[alfwatt]

Can we use hasCarrierPrivledges to avoid the potential exception in the try/catch block?

[alfwatt]

@nkukday @harvsu we're trying to test out this change and appreciate any suggestions or advice, we'll need to get a test app build together and a release to test it out

[tobrun]

Can we use hasCarrierPrivledges to avoid the potential exception in the try/catch block?

That doesn't avoid potential exceptions in the try catch block, see docs on getNetworkType

Requires Permission: READ_PHONE_STATE or that the calling app has carrier privileges (see hasCarrierPrivileges()).

The only way to avoid that exception is correctly integration of runtime permissions check. Given that this isn't possible with telemetry setup (no hook in the hosting activity), try-catch is the only thing we can do this.

[tobrun]

code LGTM but will defer the actual review to someone else :)

[harvsu]

LGTM! Instrumented unit test on this would be great!

[alfwatt]

@harvsu, @tobrun thanks for the clarifications and suggestion.

@nagineni had questions about how to verify in the test app, @harvsu do we have a step-by-step guild for using the test app to verify a snapshot build of the SDKs?

[codecov]

Codecov Report

Merging #492 into master will increase coverage by 0.14%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
+ Coverage     68.33%   68.48%   +0.14%     
- Complexity      406      408       +2     
============================================
  Files            70       70              
  Lines          2214     2221       +7     
  Branches        180      181       +1     
============================================
+ Hits           1513     1521       +8     
+ Misses          596      595       -1     
  Partials        105      105              

[harvsu]

@alfwatt Unfortunately, we do not have a step by step guild for the test app in this project. But fortunately, it is very straightforward in the main screen. We have leveraged the test app in the past to regression test the location, turnstile events and look for memory leaks. In addition, to test the differences in cross version API's, we used to create necessary build variants in the existing example app for android.

[prfarlow1]

So what are the consequences if Android apps using the Mapbox SDK do not have READ_PHONE_STATE permission? Will this library still function correctly?

[tobrun]

@prfarlow1 yes, in that case the value of data network will be network type unknown