[telemetry] Use asterisks for domain matching in CertificatePinner #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr1sunshine
force-pushed
the
mr1sunshine/fix-certs
branch
from
86644a7 to
26dbdc7
Compare
Okhttp allows to use asterisks for domain matching like: `**.square.com` for matching all subdomains. We can do the same to avoid having the list of different domains for pinning certificates.
mr1sunshine
force-pushed
the
mr1sunshine/fix-certs
branch
from
26dbdc7 to
5b24f96
Compare
Codecov Report
@@ Coverage Diff @@
## main #503 +/- ##
=======================================
Coverage ? 67.55%
Complexity ? 409
=======================================
Files ? 70
Lines ? 2244
Branches ? 187
=======================================
Hits ? 1516
Misses ? 621
Partials ? 107 |
Guardiola31337
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okhttp allows to use asterisks for domain matching like:
**.square.comfor matching all subdomains. We can do the same to avoidhaving the list of different domains for pinning certificates.