Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve non-fatal errors reporting #516

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Conversation

friendoye
Copy link
Contributor

This PR contains small improvements for non-fatal errors reporting:

  1. Custom data support was added for non-fatal errors and crashes reporting;
  2. Non-fatal errors are not sent immediately (for optimisation purpose).

Nikita Novik added 2 commits February 25, 2021 15:12
"mobile.crash" event contains "customData" field, which stores array of key-value info. This field is suitable for adding useful info for processing and addressing reported error.
The main motivation for such change is the fact we can report several non-fatal errors in a small time span. For example, imagine successful response from the server, which contains a list of records. Some of those records are invalid and we want to report non-fatal errors for such records.
@friendoye friendoye requested review from harvsu, nkukday and tarigo and removed request for harvsu February 25, 2021 13:14
Copy link
Contributor

@mr1sunshine mr1sunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants