Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetry] Workaround for MapboxTelemetryService crash. #531

Merged
merged 1 commit into from
May 24, 2021

Conversation

tarigo
Copy link
Contributor

@tarigo tarigo commented May 24, 2021

Resolves #530.

Workaround for the crash that can happen in multiple processes of WorkManager. The service functionality is tracking the lifecycle of the app's activity, so in case of background tasks, we can safely ignore this error.

@tarigo tarigo self-assigned this May 24, 2021
@tarigo tarigo requested a review from a team May 24, 2021 07:43
@tarigo tarigo changed the title [telemetry] Workaround to fix BinderProxy class cast exception. [telemetry] Workaround for MapboxTelemetryService crash. May 24, 2021
@tarigo tarigo force-pushed the tarigo_binder_proxy branch from 7497041 to e618243 Compare May 24, 2021 11:14
Copy link
Contributor

@mr1sunshine mr1sunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a question about log type.

@tarigo tarigo force-pushed the tarigo_binder_proxy branch from e618243 to 01e8b22 Compare May 24, 2021 11:27
@tarigo tarigo merged commit 420da4f into main May 24, 2021
@tarigo tarigo deleted the tarigo_binder_proxy branch May 24, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Crash in background for Android 11
2 participants