Fix TelemetryUtils.obtainApplicationState() method.
#559
Conversation
tarigo
force-pushed
the
tarigo/telemetry_utils_get_tasks_fix
branch
from
652db43 to
4785722
Compare
libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryUtils.java
Show resolved
Hide resolved
Yep, done. |
| if (appProcesses == null) { | ||
| return NO_STATE; | ||
| String state = NO_STATE; | ||
| switch (AppStateUtils.getAppStateFromActivityManager(context)) { |
There was a problem hiding this comment.
I may not see full picture but couldn't we actually expose and use AppStateUtils.getAppStateFromActivityManager(context) instead of obtainApplicationState? This mapping here seems to be actually almost 1 to 1 (at least looking at the diff here).
There was a problem hiding this comment.
Historical reasons. :) We can expose AppStateUtils.getAppStateFromActivityManager(context) but I would avoid removing obtainApplicationState cause it's a breaking change.
There was a problem hiding this comment.
Couldn't we do something like
public static String obtainApplicationState(Context context) {
return appStateUtils.getAppStateFromActivityManager(context);
}
if I get the mapping correctly?
There was a problem hiding this comment.
Well, NO_STATE is an empty string, but others are one-to-one, simplified.
tarigo
force-pushed
the
tarigo/telemetry_utils_get_tasks_fix
branch
from
b5c83c7 to
a77169a
Compare
Fixes #557.